Skip to content

Fix Singleton: inherit from NSObject #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Sources/Macros/Singleton/SingletonMacro.swift
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,18 @@ struct SingletonMacro: MemberMacro {

let nameOfDecl = try name(providingMembersOf: declaration).text
let isPublic = declaration.modifiers.map(\.name.tokenKind.keyword).contains(.public)
let initializer = try InitializerDeclSyntax("private init()") {}

// 检查是否继承自NSObject
let inheritsFromNSObject = if let classDecl = declaration.as(ClassDeclSyntax.self) {
classDecl.inheritanceClause?.inheritedTypes.contains { type in
type.type.as(IdentifierTypeSyntax.self)?.name.text == "NSObject"
} ?? false
} else {
false
}

// 根据是否继承NSObject决定init方法是否需要override
let initializer = try InitializerDeclSyntax(inheritsFromNSObject ? "private override init()" : "private init()") {}

let shared = "\(isPublic ? "public" : "") static let shared = \(nameOfDecl)()"

Expand Down