Add support for etag validation in resumableFileDownload #6042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on adding an integ test. |
alextwoods
reviewed
Apr 16, 2025
.changes/next-release/feature-AmazonS3TransferManager-21d3a50.json
Outdated
Show resolved
Hide resolved
...c/main/java/software/amazon/awssdk/transfer/s3/internal/utils/ResumableRequestConverter.java
Show resolved
Hide resolved
...ger/src/test/java/software/amazon/awssdk/transfer/s3/util/ResumableRequestConverterTest.java
Outdated
Show resolved
Hide resolved
zoewangg
reviewed
Apr 17, 2025
zoewangg
requested changes
Apr 17, 2025
| @@ -62,6 +62,11 @@ public static byte[] toJson(ResumableFileDownload download) { | |||
| jsonGenerator, | |||
| "s3ObjectLastModified"); | |||
| } | |||
| if (download.s3ObjectEtag().isPresent()) { | |||
There was a problem hiding this comment.
Can we add unit tests in ResumableFileDownloadSerializerTest?
There was a problem hiding this comment.
Good call. I added coverage for that new Etag field in the existing test. Do I need to add a standalone test just for that, or is this sufficient?
RanVaknin
force-pushed
the
rvaknin/S3Transfer-manager-resume-download-add-Etag
branch
from
9977303 to
b64302f
Compare
Yes good call. Actually the integ test I wrote caught that. Fixed now. |
zoewangg
approved these changes
Apr 17, 2025
|
alextwoods
approved these changes
Apr 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Added support for ETag validation in resumable file downloads. The Transfer Manager now validates both the
lastModifiedtimestamp and the ETag when resuming a download. This aims to make sure that if the object has changed on S3 (indicated by a different ETag), the download will restart from the beginning rather than attempting to resume, which could lead to corrupted files.Modifications
s3ObjectEtagfield toResumableFileDownloadto store the ETagResumableFileDownloadSerializerto include the ETag values.ResumableRequestConverterto compare the stored ETag with the current S3 object's ETag.Testing