-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[FLINK-37658][docs] Improve the Datagen connector docs #26455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, left some minor comments.
Signed-off-by: davidradl <david_radley@uk.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments, LGTM now.
This shall be merged after @RocMarshal vote +1.
@reswqa are you ok with the amendments to the Chinese translations that @RocMarshal has suggested instead of the ones you supplied, I am not in a position to judge! |
Yes, his suggestion is reasonable. |
Co-authored-by: Pan Yuepeng <panyuepeng@apache.org>
Co-authored-by: Pan Yuepeng <panyuepeng@apache.org>
I have included the suggested changes @RocMarshal thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davidradl for the update and @reswqa for the confirmation.
LGTM +1 now.
Amend the DataGen connector docs as agreed in PR 26437.
I have added the example from the PR into the docs and have made small improvements to the text. I have added a Chinese version of the doc change.
What is the purpose of the change
Include a length example for collections - which now works after PR 26437.
Also make minor improvements to the test in this section.
Brief change log
(for example:)
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
Doc change - this change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation