Skip to content

fix(S2): add styles prop to AlertDialog #8137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

reidbarber
Copy link
Member

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Apr 23, 2025

@rspbot
Copy link

rspbot commented Apr 23, 2025

@rspbot
Copy link

rspbot commented Apr 23, 2025

## API Changes

@react-spectrum/s2

/@react-spectrum/s2:AlertDialog

 AlertDialog {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   autoFocusButton?: 'cancel' | 'primary' | 'secondary'
   cancelLabel?: string
   children: ReactNode
   id?: string
   isPrimaryActionDisabled?: boolean
   isSecondaryActionDisabled?: boolean
   onCancel?: () => void
   onPrimaryAction?: () => void
   onSecondaryAction?: () => void
   primaryActionLabel: string
   secondaryActionLabel?: string
   size?: 'S' | 'M' | 'L' = 'M'
+  styles?: StylesProp
   title: string
   variant?: 'confirmation' | 'information' | 'destructive' | 'error' | 'warning'
 }

/@react-spectrum/s2:AlertDialogProps

 AlertDialogProps {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   autoFocusButton?: 'cancel' | 'primary' | 'secondary'
   cancelLabel?: string
   children: ReactNode
   id?: string
   isPrimaryActionDisabled?: boolean
   isSecondaryActionDisabled?: boolean
   onCancel?: () => void
   onPrimaryAction?: () => void
   onSecondaryAction?: () => void
   primaryActionLabel: string
   secondaryActionLabel?: string
   size?: 'S' | 'M' | 'L' = 'M'
+  styles?: StylesProp
   title: string
   variant?: 'confirmation' | 'information' | 'destructive' | 'error' | 'warning'
 }

@reidbarber
Copy link
Member Author

Looks like this was intentionally omitted.

@reidbarber reidbarber closed this Apr 23, 2025
@snowystinger snowystinger deleted the alertdialog-styles branch April 24, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants