Skip to content

Add composer installation to docs/welcome #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

racmanuel
Copy link

Hello, I have added how to install Secure Custom Fields in a plugin or theme using composer.

Copy link
Contributor

@priethor priethor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! I've left a couple of notes.


```php
// Hide the SCF admin menu item.
add_filter( 'acf/settings/show_admin', '__return_false' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be careful not to suggest always disabling the admin menu: what if the site using the plugin/theme uses SCF anyway?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priethor You're right, I think this should be an optional step, I'll modify it in a new commit.

Copy link
Contributor

@priethor priethor Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same goes for plugin updates. I think it should be checked whether SCF is already installed with get_plugins() before trying to hide either.

@@ -27,6 +27,76 @@ Before installing, ensure your site meets these requirements:
3. Upload the plugin folder to `/wp-content/plugins/`
4. Activate through the WordPress admin interface

### Composer Installation

This guide explains how to install and integrate the **Secure Custom Fields** plugin in your WordPress theme or plugin using Composer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a bit more about the why? A one liner with an example should be enough.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priethor I made in the new commit and pr para añadir una section about : Why integrate Secure Custom Fields (SCF) with Composer.

@priethor priethor added the documentation Improvements or additions to documentation label Apr 14, 2025
…ts, and optional admin menu and update notification hiding

docs: update SCF installation guide with Composer integration, benefits, and optional admin menu and update notification hiding
@racmanuel racmanuel requested a review from priethor April 14, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants