-
Notifications
You must be signed in to change notification settings - Fork 24
Add composer installation to docs/welcome #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this! I've left a couple of notes.
|
||
```php | ||
// Hide the SCF admin menu item. | ||
add_filter( 'acf/settings/show_admin', '__return_false' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be careful not to suggest always disabling the admin menu: what if the site using the plugin/theme uses SCF anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@priethor You're right, I think this should be an optional step, I'll modify it in a new commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same goes for plugin updates. I think it should be checked whether SCF is already installed with get_plugins()
before trying to hide either.
docs/welcome/installation.md
Outdated
@@ -27,6 +27,76 @@ Before installing, ensure your site meets these requirements: | |||
3. Upload the plugin folder to `/wp-content/plugins/` | |||
4. Activate through the WordPress admin interface | |||
|
|||
### Composer Installation | |||
|
|||
This guide explains how to install and integrate the **Secure Custom Fields** plugin in your WordPress theme or plugin using Composer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a bit more about the why
? A one liner with an example should be enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@priethor I made in the new commit and pr para añadir una section about : Why integrate Secure Custom Fields (SCF) with Composer.
…ts, and optional admin menu and update notification hiding docs: update SCF installation guide with Composer integration, benefits, and optional admin menu and update notification hiding
Hello, I have added how to install Secure Custom Fields in a plugin or theme using composer.