Skip to content

FlashList v2 #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

FlashList v2 #1617

wants to merge 38 commits into from

Conversation

naqvitalha
Copy link
Collaborator

Description

This PR adds a new core for new arch that will replace recyclerlistview dependency.

Reviewers’ hat-rack 🎩

  • [ ]

Screenshots or videos (if needed)


import App from "./src/App";
import { name as appName } from "./app.json";

I18nManager.forceRTL(false);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete this?

}
}, [currentStickyIndex, nextStickyIndex, recyclerViewManager, sortedIndices]);

useEffect(() => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naqvitalha Maybe the bug we saw is because the current index is computed in a useEffect instead of a layout effect. This would be computed well after pain right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants