Forcing specific weapon by target type #1631
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
|
besides, if you're certain that weapons of a techno won't make use of the following things, you can use this ability to make it skip previous weapon index picking logic, to save some calculation cost
a similar optimization was also made in #1568 |
CrimRecya
approved these changes
Apr 19, 2025
|
|
||
| if (pTypeExt->ForceWeapon_Defenses >= 0) | ||
| { | ||
| auto const pBuildingType = abstract_cast<BuildingTypeClass*>(pTargetTechno->GetTechnoType()); |
There was a problem hiding this comment.
auto const pBuildingType = static_cast<BuildingClass*>(pTargetTechno)->Type;
or auto const pBuildingType = static_cast<BuildingTypeClass*>(pTargetType);
Comment on lines
+148
to
+156
| case AbstractType::Unit: | ||
| { | ||
| if (pTypeExt->ForceAAWeapon_Units >= 0 && pTarget->IsInAir()) | ||
| forceWeaponIndex = pTypeExt->ForceAAWeapon_Units; | ||
| else | ||
| forceWeaponIndex = pTypeExt->ForceWeapon_Units; | ||
|
|
||
| break; | ||
| } |
There was a problem hiding this comment.
I think you can also add a ForceWeapon.Naval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a supplement for #1630. With multiple weapons being set, you can use
ForceWeaponto enable them when attacking different targets. This pull request is a basic one that should be enough for many casesForceWeapon.Defensesis enabled, it'll be used if the target is a building withIsBaseDefense=yes. Otherwise it'll followForceWeapon.Buildings, if enabled.ForceWeapon.Infantry/Units/Aircraftcan be applied to both ground and air target ifForceAAWeapon.Infantry/Units/Aircraftis not set.ForceAAWeapon.Infantry/Units/Aircraftdo the same things but only for air target. Taking priority toForceWeapon.Infantry/Units/Aircraft, which means that they can only be applied to ground target when they're both set.In
rulesmd.ini: