fix: Ensure X_test does not get overwritten
#10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Previously due to a overfit/underfit/goodfit sample, which also used the variable `X_test`, the students/users were in for a nasty surprise when they tried to work with `X_test` -- it had completely different dimensions. * This commit ensures that the variable does not get shadowed inside that particular `for` loop. Signed-off-by: mr.Shu <mr@shu.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously due to a overfit/underfit/goodfit sample, which also used
the variable
X_test, the students/users were in for a nasty surprisewhen they tried to work with
X_test-- it had completely differentdimensions.
This commit ensures that the variable does not get shadowed inside
that particular
forloop.Signed-off-by: mr.Shu mr@shu.io