fix config file #4192
Open
fix config file #4192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vanshanium
reviewed
Apr 21, 2025
There was a problem hiding this comment.
The Piece of code you have deleted use to ask users to input the frame rate, resolution etc. Due to which only 1080x1920 is being set as the default. So, it fixes the issue but its making it less useful, and with this CFG_DEFAULTS dictionary and this Update_cfg on line 62 is completely redundant now.
The simplest way to resolve this might be done by just swaping the the resolution at line 32.
|
The problem I saw and tried to address is that the removed code was reimplementing make_config_parser. I don't think it would be an issue to add back the prompting, I'll check and get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4184
Overview: What does this pull request change?
Motivation and Explanation: Why and how do your changes improve the library?
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist