Skip to content

CompatHelper: bump compat for JET to 0.10 for package DifferentiationInterfaceTest, (keep existing compat) #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the JET package from 0.4 - 0.8, 0.9 to 0.4 - 0.8, 0.9, 0.10 for package DifferentiationInterfaceTest.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot requested a review from gdalle as a code owner March 29, 2025 01:52
@gdalle gdalle force-pushed the compathelper/new_version/2025-03-29-01-52-08-306-03408240255 branch from c6c09af to d1c7fb9 Compare March 29, 2025 01:52
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (51c56e8) to head (d1c7fb9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #761   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files         128      128           
  Lines        7444     7444           
=======================================
  Hits         7286     7286           
  Misses        158      158           
Flag Coverage Δ
DI 98.94% <ø> (ø)
DIT 95.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gdalle gdalle added the wontfix This will not be worked on label Mar 29, 2025
@gdalle
Copy link
Member

gdalle commented Mar 29, 2025

Given what is said about JET v0.10 in the release notes, I think we should not merge this until the transitional phase has stabilized. For instance, v0.10.0 doesn't support report_package.

https://github.com/aviatesk/JET.jl/releases/tag/v0.10.0

Copy link
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge

@gdalle gdalle marked this pull request as draft March 31, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant