Skip to content

Implement eltype for list #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

saolof
Copy link

@saolof saolof commented Jun 14, 2021

...Otherwise this can be a very easy to miss source of type instability. Adding this line gave me a fivefold speedup on a problem I had

...Otherwise this is a very easy source of type instability
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2021

Codecov Report

Merging #68 (1bea603) into master (2dd9b36) will decrease coverage by 0.80%.
The diff coverage is 0.00%.

❗ Current head 1bea603 differs from pull request most recent head fb3bb25. Consider uploading reports for the commit fb3bb25 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   77.30%   76.50%   -0.81%     
==========================================
  Files           7        7              
  Lines         379      383       +4     
==========================================
  Hits          293      293              
- Misses         86       90       +4     
Impacted Files Coverage Δ
src/PersistentList.jl 64.00% <0.00%> (-5.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd9b36...fb3bb25. Read the comment docs.

@saolof
Copy link
Author

saolof commented Jun 14, 2021

I'm seeing that #39 tried making a PR to do this several years ago, but that the build would fail and the PR didn't get merged. This does in fact implement the same functionality but the build seems to pass.

I'll try adding the full set of Tests from that PR with the names fixed so that they work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants