Skip to content

fix test windows in CI #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

fix test windows in CI #63

merged 1 commit into from
Apr 16, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 16, 2025

similar changes were made in IntelPython/mkl_random#62

@vtavana vtavana self-assigned this Apr 16, 2025
@vtavana vtavana marked this pull request as ready for review April 16, 2025 05:51
@Copilot Copilot AI review requested due to automatic review settings April 16, 2025 05:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.github/workflows/build-with-clang.yml:7

  • The 'pull_request:' event trigger appears to be defined twice in this workflow, which could lead to unexpected behavior. Consider consolidating the event triggers into a single definition to avoid ambiguity.
  pull_request:

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vtavana vtavana merged commit 7f2a181 into master Apr 16, 2025
17 checks passed
@vtavana vtavana deleted the win_CI branch April 16, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants