🎨 docker-api-proxy always requires authentication (⚠️devops)
#7586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7586 +/- ##
==========================================
+ Coverage 87.06% 87.73% +0.66%
==========================================
Files 1726 1767 +41
Lines 66633 68233 +1600
Branches 1125 1123 -2
==========================================
+ Hits 58017 59864 +1847
+ Misses 8324 8062 -262
- Partials 292 307 +15
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
GitHK
changed the title
docker-api-proxy always requires authentication nowdocker-api-proxy always requires authentication now (⚠️devops)
added 2 commits
April 25, 2025 13:23
…ic-auth-to-docker-api-proxy
GitHK
changed the title
docker-api-proxy always requires authentication now (⚠️devops)docker-api-proxy always requires authentication (⚠️devops)
GitHK
requested review from
sanderegg,
mrnicegyu11,
YuryHrytsuk and
pcrespov
as code owners
giancarloromeo
approved these changes
Apr 25, 2025
mrnicegyu11
reviewed
Apr 25, 2025
pcrespov
approved these changes
Apr 25, 2025
services/docker-api-proxy/tests/integration/test_docker_api_proxy.py
Outdated
Show resolved
Hide resolved
added 5 commits
April 28, 2025 10:55
|
@Mergifyio queue |
🟠 Waiting for conditions to match
|
|
YuryHrytsuk
reviewed
Apr 28, 2025
| @@ -12,4 +12,7 @@ echo "$INFO" "User :$(id "$(whoami)")" | |||
| # | |||
| # RUNNING application | |||
| # | |||
| socat TCP-LISTEN:8888,fork,reuseaddr UNIX-CONNECT:/var/run/docker.sock | |||
| socat TCP-LISTEN:8889,fork,reuseaddr UNIX-CONNECT:/var/run/docker.sock & | |||
There was a problem hiding this comment.
What is it for? Why do we need it?
YuryHrytsuk
reviewed
Apr 28, 2025
| :8888 { | ||
| handle { | ||
| basicauth { | ||
| {$DOCKER_API_PROXY_USER} {$DOCKER_API_PROXY_ECRYPTED_PASSWORD} |
There was a problem hiding this comment.
Suggested change
| {$DOCKER_API_PROXY_USER} {$DOCKER_API_PROXY_ECRYPTED_PASSWORD} | |
| {$DOCKER_API_PROXY_USER} {$DOCKER_API_PROXY_ENCRYPTED_PASSWORD} |
YuryHrytsuk
requested changes
Apr 28, 2025
| @@ -0,0 +1,11 @@ | |||
| :8888 { | |||
| handle { | |||
There was a problem hiding this comment.
Let me see how we can configre IP Whitelisting in Caddy before we go ahead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue/s
docker-api-proxyshall require basic auth #7223How to test