Move the Spline tool to a spline/path mode option in the Pen tool

[indierusty]

No description provided.

[Keavon]

Can you please resolve these merge conflicts?

[Keavon]

I'll mark this as draft for the moment. Please make it ready for review when you've finished the conflict and making it compile again. Thank you!

[Keavon]

!build

[github-actions]

📦 Build Complete for ed83b84
https://e7982ec2.graphite.pages.dev

[Keavon]

!build

[github-actions]

📦 Build Complete for 32ed4bd
https://aae4be41.graphite.pages.dev

[Keavon]

If you get a chance soon to resolve the conflicts, I can do a code review and prepare to merge it now that I finally have the time to put my attention towards this. Thanks and sorry for the delay on my part causing you the extra work.

[indierusty]

If you get a chance soon to resolve the conflicts, I can to a code review and prepare to merge it now that I finally have the time to put my attention towards this. Thanks and sorry for the delay on my part causing you the extra work.

No problem about the delay. I was actually sick for a few days but I'm back today and ready to work on tasks I'm assigned to. I'll get this conflicts resolved.

[Keavon]

Right clicking to end drawing the spline results in the whole new spline layer being deleted. It looks like this was intentional because of how the hints are shown. But we'll want to make it reflect the regular (path mode) Pen tool behavior of confirming all previously drawn segments but canceling the currently-being-extended segment; and if the user is clicking and dragging to slide around the new proposed segment, in that case Enter should accept it where it is while Esc/RMB should cancel that currently-being-placed-and-sliding segment. So in summary, if the mouse is up, Enter/Esc/RMB behave equivalently, but if the mouse is down and sliding, Esc/RMB behave differently from Enter. Check the Pen tool (path mode) for how that works and look at the input hints shown for both cases.

[Keavon]

It looks like we lose the functionality that we currently have in master where the Pen tool can extend a Spline tool spline from its endpoint, creating the necessary node changes to support that. But now that I think about it, I think it might be better to just keep it this way for simplicity at this time. We're likely to use a more spreadsheet/attribute-oriented approach in the future for marking which anchors should be treated as a spline, that way the node graph can be considerably simplified. (Pending further progress on #1832 and #2522.)

[indierusty]

I tried to read all the changes made to spline tool but I probably missed it.

[indierusty]

It looks like we lose the functionality that we currently have in master where the Pen tool can extend a Spline tool spline from its endpoint, creating the necessary node changes to support that. But now that I think about it, I think it might be better to just keep it this way for simplicity at this time. We're likely to use a more spreadsheet/attribute-oriented approach in the future for marking which anchors should be treated as a spline, that way the node graph can be considerably simplified. (Pending further progress on #1832 and #2522.)

I think we can still extend the spline created in spline mode using path mode as path tool modifies the path node that feeds the spline node.

[Keavon]

Consensus on our call together: replace this PR with one that reimplements the desired functionality: a "Polyline" mode that opts out of handle-dragging behavior in the Pen tool, and a "Spline" mode that is just "Polyline" mode but with the inclusion of a Spline node in the layer that's created.