chore: examples module #131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anssari1
reviewed
Apr 22, 2025
examples/src/main/java/com/expediagroup/sdk/xap/examples/XapSdkDemoTestRun.java
Outdated
Show resolved
Hide resolved
| <artifactId>maven-checkstyle-plugin</artifactId> | ||
| <version>3.6.0</version> | ||
| <configuration> | ||
| <configLocation>google_checks.xml</configLocation> |
There was a problem hiding this comment.
Can we please add this checkstyle plugin?
… headers and default string type
…transformedSpecs.yaml
Mohammad-Dwairi
previously approved these changes
Apr 28, 2025
OmarAlJarrah
dismissed
Mohammad-Dwairi’s stale review
The base branch was changed.
anssari1
reviewed
Apr 28, 2025
| @@ -33,140 +33,160 @@ | |||
| */ | |||
| public class CarListingsQuickStartScenario implements XapScenario { | |||
|
|
|||
| private static final Logger LOGGER = LoggerFactory.getLogger(CarListingsQuickStartScenario.class); | |||
There was a problem hiding this comment.
Can we please undo the indentation changes to focus on the code changes?
There was a problem hiding this comment.
Auto-formatted the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
After the efforts we have put onto redesigning our SDK platform, we are aiming to integrate the XAP SDK with the new platform tools.
The scope for this PR is to delete code and maven settings to initiate the ground for migrating to new SDK core.
Task
Add and configure
examplesmodule.Action
Added and configured
examplesmodule.Testing
NaN
Results
NaN
Notes
NaN