-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update flood_inundation_mapping_using_sar_data_and_deep_learning.ipynb #2259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
updated the notebook
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
View / edit / reply to this conversation on ReviewNB neha-sharma-geoai commented on 2025-04-16T05:32:31Z Should we not hide our usernames in the output path and prevent them from showing to users? |
View / edit / reply to this conversation on ReviewNB neha-sharma-geoai commented on 2025-04-16T05:32:32Z The zoom level is to be given in a new cell after the map has rendered. Are we not syncing the three maps? If we sync, we need to define zoom level only once (in a new cell). shivanip32 commented on 2025-04-16T05:41:14Z this is also working fine. neha-sharma-geoai commented on 2025-04-16T05:56:46Z That's okay, but repeated lines make it look redundant. We don't need to give the zoom level thrice. It's great if it's working like this, but as I learned from the map team, it should be given in a new cell after the map has rendered. Maybe it's updated now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shivanip32
Please check the comments.
this is also working fine. View entire conversation on ReviewNB |
That's okay, but repeated lines make it look redundant. We don't need to give the zoom level thrice. It's great if it's working like this, but as I learned from the map team, it should be given in a new cell after the map has rendered. Maybe it's updated now. View entire conversation on ReviewNB |
View / edit / reply to this conversation on ReviewNB neha-sharma-geoai commented on 2025-04-18T06:20:31Z L of Learning should be small or else P and C of pixel classification should be capital. |
View / edit / reply to this conversation on ReviewNB neha-sharma-geoai commented on 2025-04-18T06:20:32Z This import is repeated, and it's not importing correctly here. |
View / edit / reply to this conversation on ReviewNB neha-sharma-geoai commented on 2025-04-18T06:20:33Z Please check the grammar. |
View / edit / reply to this conversation on ReviewNB neha-sharma-geoai commented on 2025-04-18T06:20:34Z Should we take this import to first cell? |
View / edit / reply to this conversation on ReviewNB neha-sharma-geoai commented on 2025-04-18T06:20:35Z Please check spellings and grammar. |
updated the notebook
<insert pull request description here>
Checklist
Please go through each entry in the below checklist and mark an 'X' if that condition has been met. Every entry should be marked with an 'X' to be get the Pull Request approved.
import
s are in the first cell?arcgis
imports? Note that in some cases, for samples, it is a good idea to keep the imports next to where they are used, particularly for uncommonly used features that we want to highlight.GIS
object instantiations are one of the following?gis = GIS()
gis = GIS('home')
orgis = GIS('pro')
gis = GIS(profile="your_online_portal")
gis = GIS(profile="your_enterprise_portal")
./misc/setup.py
and/or./misc/teardown.py
?api_data_owner
user?api_data_owner
account and change the notebook to first download and unpack the files.<img src="base64str_here">
instead of<img src="https://some.url">
? All map widgets contain a static image preview? (Callmapview_inst.take_screenshot()
to do so)os.path.join()
? (Instead ofr"\foo\bar"
,os.path.join(os.path.sep, "foo", "bar")
, etc.)Export Training Data Using Deep Learning
tool published on geosaurus org (api data owner account) and added in the notebook usinggis.content.get
function?gis.content.get
function? Note: This includes providing test raster and trained model.