Skip to content

[CLOUDCRAFT-1201] Component: DynamoDB #28953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 28, 2025
Merged

[CLOUDCRAFT-1201] Component: DynamoDB #28953

merged 4 commits into from
Apr 28, 2025

Conversation

jamesponddotco
Copy link
Contributor

What does this PR do? What is the motivation?

Add documentation for the Cloudcraft component "DynamoDB", which was missing from our list of components.

Merge instructions

Merge readiness:

  • Ready for merge

@jamesponddotco
Add ref doc for the DynamoDB component
e3e7065 
Signed-off-by: James Pond <james.pond@datadoghq.com>
@jamesponddotco
Add DynamoDB doc to the index
4a1817d 
Signed-off-by: James Pond <james.pond@datadoghq.com>
@jamesponddotco
Add DynamoDB images
5f58dc2 
Signed-off-by: James Pond <james.pond@datadoghq.com>
@jamesponddotco jamesponddotco requested a review from a team April 24, 2025 14:05
@jamesponddotco jamesponddotco requested a review from a team as a code owner April 24, 2025 14:06
@github-actions github-actions bot added the Images Images are added/removed with this PR label Apr 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

@domalessi domalessi self-assigned this Apr 24, 2025
domalessi
domalessi reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@domalessi domalessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suuuuper nit picky suggestions. Overall, looks great! Give my comments a review and hit me up when ready for final sign-off.

@jamesponddotco
Apply review suggestions
dc11b34 
Signed-off-by: James Pond <james.pond@datadoghq.com>
@jamesponddotco
Copy link
Contributor Author

@domalessi Ready for re-review :)

domalessi
domalessi approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@domalessi domalessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@jamesponddotco
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 28, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-28 17:22:34 UTC ℹ️ Start processing command /merge

2025-04-28 17:22:40 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 19m (p90).

2025-04-28 17:40:28 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 1a58fe8 into master Apr 28, 2025
16 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the james.pond/cloudcraft-1201-add-dynamodb branch April 28, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domalessi domalessi domalessi approved these changes

Assignees

@domalessi domalessi

Labels
Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesponddotco @domalessi