Skip to content

Remove files generated by FE builds #10067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

msabramo
Copy link
Contributor

These probably shouldn't be necessary and are bloating the repo and making it harder to work with the code.

Type

🧹 Refactoring

Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2025 10:39pm

These probably shouldn't be necessary and are bloating the repo and
making it harder to work with the code.
@msabramo msabramo force-pushed the remove-generated-files branch from 754157a to 6d10b1a Compare April 17, 2025 22:38
@msabramo
Copy link
Contributor Author

msabramo commented Apr 17, 2025

Fixed merge conflict. Consider merging soon if possible to minimize merge conflicts.

@krrishdholakia @ishaan-jaff

@krrishdholakia
Copy link
Contributor

Screenshot 2025-04-17 at 6 26 06 PM

Hey @msabramo the proxy uses this folder

@msabramo
Copy link
Contributor Author

Can’t you build the FE files in your CI?

Having them in git is very strange and it causes annoyances when working with the code because they easily become modified and then you can’t switch branches without first throwing them away. Much easier to not have them in git.

@krrishdholakia
Copy link
Contributor

Yes - we should.

Since this PR is blocked on that change, we can either close this out for now or refactor this to incorporate the change.

@CLAassistant
Copy link

CLAassistant commented Apr 22, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants