[trello.com/c/vawidi4o] Add UI for Secret Wallets and combine it with a new secret wallet service #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lainaaa
force-pushed
the
trello.com/c/vawidi4o
branch
2 times, most recently
from
695ff78 to
5de4a89
Compare
Lainaaa
force-pushed
the
trello.com/c/vawidi4o
branch
from
5de4a89 to
8a30c23
Compare
ChrisBenua
reviewed
Mar 1, 2025
ChrisBenua
reviewed
Mar 1, 2025
…of wallet section and address row.
# Conflicts: # Adamant/App/DI/AppAssembly.swift # Adamant/Modules/Account/AccountViewController/AccountViewController.swift # Adamant/Modules/Account/AccountViewController/AccountWallets/AccountWalletsViewModel.swift
Lainaaa
changed the title
Lainaaa
force-pushed
the
trello.com/c/vawidi4o
branch
from
a4d95c1 to
e7fb916
Compare
Lainaaa
force-pushed
the
trello.com/c/vawidi4o
branch
from
521fb14 to
a88f45e
Compare
vovameister
approved these changes
Mar 31, 2025
PingPongEzZ
reviewed
Mar 31, 2025
Adamant/Modules/Account/AccountViewController/AccountViewController.swift
Outdated
Show resolved
Hide resolved
PingPongEzZ
approved these changes
Mar 31, 2025
…ntHeaderView.swift
Lainaaa
commented
Apr 1, 2025
[trello.com/c/YsjIF3DY] (Secret wallets) Handle logout/login case
[trello.com/c/Aw0Vfnmd] {Secret wallets} UI: Show Transactions 🔐 1️⃣
[trello.com/c/hzqPFC5l] Update "Send Crypto" screen to use with secret wallets
# Conflicts: # Adamant.xcodeproj/project.pbxproj # Adamant/App/DI/AppAssembly.swift # Adamant/Modules/Account/AccountHeaderView.swift # Adamant/Modules/Account/AccountViewController/AccountViewController+Form.swift # Adamant/Modules/Account/AccountViewController/AccountViewController.swift # Adamant/Modules/Account/AccountViewController/AccountWallets/AccountWalletsViewModel.swift # Adamant/Modules/Delegates/DelegateDetailsViewController.swift # Adamant/Modules/Settings/PKGenerator/PKGeneratorState.swift # Adamant/Modules/Settings/PKGenerator/PKGeneratorView.swift # Adamant/Modules/Settings/PKGenerator/PKGeneratorViewModel.swift # Adamant/Modules/Settings/PrivateKeyGenerator.swift # Adamant/Modules/Wallets/Adamant/AdmWalletService.swift # Adamant/Modules/Wallets/Bitcoin/BtcWalletService.swift # Adamant/Modules/Wallets/Bitcoin/BtcWalletViewController.swift # Adamant/Modules/Wallets/Dash/DashWalletService.swift # Adamant/Modules/Wallets/Dash/DashWalletViewController.swift # Adamant/Modules/Wallets/Doge/DogeWalletService.swift # Adamant/Modules/Wallets/Doge/DogeWalletViewController.swift # Adamant/Modules/Wallets/ERC20/ERC20WalletService.swift # Adamant/Modules/Wallets/ERC20/ERC20WalletViewController.swift # Adamant/Modules/Wallets/EthBIP32Service/EthBIP32Service.swift # Adamant/Modules/Wallets/Ethereum/EthWalletService.swift # Adamant/Modules/Wallets/Ethereum/EthWalletViewController.swift # Adamant/Modules/Wallets/Klayr/KlyWalletViewController.swift # Adamant/Modules/Wallets/Klayr/WalletService/KlyWalletService+WalletCore.swift # Adamant/Modules/Wallets/Klayr/WalletService/KlyWalletService.swift # Adamant/Modules/Wallets/TransactionDetailsViewControllerBase.swift # Adamant/Modules/Wallets/TransactionsListViewControllerBase.swift # Adamant/Modules/Wallets/TransferViewControllerBase.swift # Adamant/Modules/Wallets/WalletViewControllerBase.swift # Adamant/ServiceProtocols/DialogService.swift # Adamant/ServiceProtocols/SecretWalletsManagerProtocol.swift # Adamant/Services/AdamantAccountService.swift # Adamant/Services/AdamantCoinStorageService.swift # Adamant/Services/AdmDialogService/AdamantDialogService.swift # Adamant/Services/SecretWalletsFactory.swift # Adamant/Services/SecretWalletsManager.swift
# Conflicts: # Adamant/Modules/Account/AccountViewController/AccountViewController.swift
Lainaaa
force-pushed
the
trello.com/c/vawidi4o
branch
from
8f3f34d to
e03d451
Compare
… in a carousel when switching between secrets and regular.
[trello.com/c/1SZ08BQ6] Add appropriate naming related to secret wallets
[trello.com/c/ONt29HWW] Save the index of the current selected crypto in a carousel when switching between secrets and regular.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info available by task link.
For managing secret wallets uses alert menu.
For my view it does not need to be explained even while it looks as big PR. If you would have any questions I am open for that!
Please, take a look at my secret wallet factory because i am not sure about its implementation.