Skip to content

Commit 2cd8064

Browse files
committed
fix old classmap in composer.json
fix some scrutinizer advices.
1 parent d37af62 commit 2cd8064

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

composer.json

+1-4
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"Structured Data",
99
"markup",
1010
"google",
11-
"Google's Structured Data Testing Tool",
11+
"Google Structured Data Testing Tool",
1212
"API"
1313
],
1414
"homepage": "https://github.com/padosoft/laravel-google-structured-data-testing-tool",
@@ -41,9 +41,6 @@
4141
}
4242
},
4343
"autoload-dev": {
44-
"classmap": [
45-
"tests/TestCase.php"
46-
],
4744
"psr-4": {
4845
"Padosoft\\Laravel\\Google\\StructuredDataTestingTool\\Test\\": "tests"
4946
}

src/GoogleStructuredDataTestTool.php

+13-4
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
namespace Padosoft\Laravel\Google\StructuredDataTestingTool;
44

5-
use Illuminate\Console\Command;
65
use Config;
6+
use Illuminate\Console\Command;
77

88
class GoogleStructuredDataTestTool extends Command
99
{
@@ -121,23 +121,32 @@ private function notifyResult($mail, $nomailok, $tuttoOk)
121121
$this->notify($tuttoOk);
122122
}
123123

124-
124+
/**
125+
* @param boolean $result
126+
*/
125127
private function notify($result)
126128
{
127129
if ($result) {
128-
return $this->notifyOK();
130+
$this->notifyOK();
131+
return;
129132
}
130133

131134
$this->notifyKO();
132135
}
133136

137+
/**
138+
*
139+
*/
134140
private function notifyOK()
135141
{
136142
$esito = Config::get('laravel-google-structured-data-testing-tool.mailSubjectSuccess');
137143
$this->line('<info>'.$esito.'</info>');
138144
$this->line('');
139145
}
140146

147+
/**
148+
*
149+
*/
141150
private function notifyKO()
142151
{
143152
$esito = Config::get('laravel-google-structured-data-testing-tool.mailSubjetcAlarm');
@@ -147,7 +156,7 @@ private function notifyKO()
147156

148157
/**
149158
* @param $mail
150-
* @param $tuttoOk
159+
* @param boolean $tuttoOk
151160
*/
152161
private function sendEmail($mail, $tuttoOk)
153162
{

0 commit comments

Comments
 (0)