Skip to content

Fix white header visible when we scroll down #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rumfiske opened this issue Aug 22, 2023 · 4 comments · Fixed by #62
Closed

Fix white header visible when we scroll down #61

rumfiske opened this issue Aug 22, 2023 · 4 comments · Fixed by #62

Comments

@rumfiske
Copy link

Pleaske make props for theese 2 CSS settings so we can put 0 as elevation and transparent for header.
Code_p5pEPrrKMh

@kanelloc kanelloc linked a pull request Sep 2, 2023 that will close this issue
13 tasks
@kanelloc
Copy link
Owner

kanelloc commented Sep 2, 2023

Please check the above PR, update to the latest package and let me know if have any other issue

@rumfiske
Copy link
Author

rumfiske commented Sep 2, 2023

Still same issue. We need to have a prop for this specific style. Still need to change it manually. :( But good work with everything else bro
Code_JhniVIRdyT
Airplay_KyK51xRetn

@kanelloc
Copy link
Owner

kanelloc commented Sep 2, 2023

@rumfiske can you attach a video to understand exactly the use case?
I'm testing it locally with different background colors and it works as expected on both light/dark mode.

If you run locally the examples you can see that header is color: tomato without any white border

@kanelloc kanelloc reopened this Sep 2, 2023
@rumfiske
Copy link
Author

rumfiske commented Apr 11, 2024

It has to be a value that can be dynamicly set, right now its hardcoded into the component. I fixed it my self the PR is here ->#102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants