Skip to content

Multiple line support for trailers and breaking change values #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pkryger opened this issue Mar 12, 2025 · 3 comments
Closed

Multiple line support for trailers and breaking change values #76

pkryger opened this issue Mar 12, 2025 · 3 comments

Comments

@pkryger
Copy link

pkryger commented Mar 12, 2025

According to git-interpret-trailers
Documentation
trailer values
can be split over multiple lines. It seems that there was support for such a
behaviour added in #49. The functionality has been dropped when added support
for overflow in #64, but I cannot find a reason for it. The overflow support
has been subsequently removed in #68, unfortunately the multiple line trailer
values has not been reinstated. Can it be added again?

While on it, I believe that breaking change values should be also allowed to
span multiple line. Although, the BREAKING CHANGE doesn't conform to a
trailer key definition due to the whitespace(but BREAKING-CHANGE does!), I
believe that allowing multiple lines for a value will be beneficial: just the
key and a separator consume 17 characters, and an explanation may take more
than just a words (assuming: one cares about overflow).

I did a small test on my local
branch
. Happy
to create a PR if that's something desireable.

@gbprod
Copy link
Owner

gbprod commented Mar 12, 2025

You're right !
I try to restore this soon

@gbprod
Copy link
Owner

gbprod commented Mar 13, 2025

Should be fixed now !

@gbprod gbprod closed this as completed Mar 13, 2025
@pkryger
Copy link
Author

pkryger commented Mar 13, 2025

Thank you very much for a speedy reaction! It works as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants