fix: make some Azure pipeline env vars optional (#1896)

Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>

Author: jiparis

pkg/attestation/crafter/runners/azurepipeline.go

@@ -46,16 +46,15 @@ func (r *AzurePipeline) CheckEnv() bool {
 
 func (r *AzurePipeline) ListEnvVars() []*EnvVarDefinition {
 	return []*EnvVarDefinition{
-		{"BUILD_REQUESTEDFOREMAIL", false},
+		{"BUILD_REQUESTEDFOREMAIL", true},
 		{"BUILD_REQUESTEDFOR", false},
-		{"BUILD_REPOSITORY_URI", false},
-		{"BUILD_REPOSITORY_NAME", false},
+		{"BUILD_REPOSITORY_URI", true},
+		{"BUILD_REPOSITORY_NAME", true},
 		{"BUILD_BUILDID", false},
 		{"BUILD_BUILDNUMBER", false},
 		{"BUILD_BUILDURI", false},
-		{"BUILD_REASON", false},
-		{"AGENT_VERSION", false},
-		{"TF_BUILD", false},
+		{"BUILD_REASON", true},
+		{"TF_BUILD", true},
 	}
 }
 

pkg/attestation/crafter/runners/azurepipeline_test.go

@@ -79,16 +79,15 @@ func (s *azurePipelineSuite) TestCheckEnv() {
 
 func (s *azurePipelineSuite) TestListEnvVars() {
 	assert.Equal(s.T(), []*EnvVarDefinition{
-		{"BUILD_REQUESTEDFOREMAIL", false},
+		{"BUILD_REQUESTEDFOREMAIL", true},
 		{"BUILD_REQUESTEDFOR", false},
-		{"BUILD_REPOSITORY_URI", false},
-		{"BUILD_REPOSITORY_NAME", false},
+		{"BUILD_REPOSITORY_URI", true},
+		{"BUILD_REPOSITORY_NAME", true},
 		{"BUILD_BUILDID", false},
 		{"BUILD_BUILDNUMBER", false},
 		{"BUILD_BUILDURI", false},
-		{"BUILD_REASON", false},
-		{"AGENT_VERSION", false},
-		{"TF_BUILD", false},
+		{"BUILD_REASON", true},
+		{"TF_BUILD", true},
 	}, s.runner.ListEnvVars())
 }
 
@@ -97,7 +96,6 @@ func (s *azurePipelineSuite) TestResolveEnvVars() {
 	s.Empty(errors)
 
 	s.Equal(map[string]string{
-		"AGENT_VERSION":           "3.220.5",
 		"BUILD_BUILDID":           "6",
 		"BUILD_BUILDNUMBER":       "20230726.5",
 		"BUILD_BUILDURI":          "vstfs:///Build/Build/6",