Skip to content

Commit 76dc08a

Browse files
committed
clean up some todos
1 parent 51580d7 commit 76dc08a

File tree

5 files changed

+2
-7
lines changed

5 files changed

+2
-7
lines changed

packages/@react-aria/utils/src/useLoadMore.ts

-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ export function useLoadMore(props: LoadMoreProps, ref: RefObject<HTMLElement | n
5151
let triggerLoadMore = useEffectEvent((entries: IntersectionObserverEntry[]) => {
5252
// Use "isIntersecting" over an equality check of 0 since it seems like there is cases where
5353
// a intersection ratio of 0 can be reported when isIntersecting is actually true
54-
// TODO: firefox seems to gather multiple entries, will need to reproduce in a base repro
5554
for (let entry of entries) {
5655
if (entry.isIntersecting && !isLoading && !(collection && collectionAwaitingUpdate.current) && onLoadMore) {
5756
onLoadMore();

packages/react-aria-components/src/ComboBox.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ export interface ComboBoxRenderProps {
4949
*/
5050
isRequired: boolean,
5151
// TODO: do we want loadingState for RAC Combobox or just S2
52-
// TODO: move types somewhere common later
5352
/**
5453
* Whether the combobox is currently loading items.
5554
* @selector [data-loading]

packages/react-aria-components/src/GridList.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -528,7 +528,6 @@ export const UNSTABLE_GridListLoadingIndicator = createLeafComponent('loader', f
528528
return (
529529
<div
530530
role="row"
531-
// TODO: do we need any of the other row props from useGridListItem? Rather not grab too much if this is all we need
532531
aria-rowindex={isVirtualized ? item.index + 1 : undefined}
533532
ref={ref}
534533
{...mergeProps(filterDOMProps(props as any))}

packages/react-aria-components/src/ListBox.tsx

+2-3
Original file line numberDiff line numberDiff line change
@@ -248,9 +248,8 @@ function ListBoxInner<T extends object>({state: inputState, props, listBoxRef}:
248248
// dropdown opens but the current state gives the user more freedom as to whether they would like to pre-fetch or not
249249
useLoadMore(memoedLoadMoreProps, listBoxRef);
250250

251-
// TODO: add loading indicator to ListBox so user can render that when loading. Think about if completely empty state
252-
// do we leave it up to the user to setup the two states for empty and empty + loading? Do we add a data attibute/prop/renderprop to ListBox
253-
// for isLoading
251+
// TODO: Think about if completely empty state. Do we leave it up to the user to setup the two states for empty and empty + loading?
252+
// Do we add a data attibute/prop/renderprop to ListBox for isLoading
254253
return (
255254
<FocusScope>
256255
<div

packages/react-aria-components/src/Select.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ export interface SelectRenderProps {
6060
* @selector [data-required]
6161
*/
6262
isRequired: boolean,
63-
// TODO: move types somewhere common later
6463
/**
6564
* Whether the select is currently loading items.
6665
* @selector [data-loading]

0 commit comments

Comments
 (0)